1. modularize /goal logic - #2184

Note

Medium Risk
Refactors goal accounting and persistence paths that affect continuations and budget limits; behavior is intended to be unchanged but ordering invariants must stay correct.

Overview
Extracts goal lifecycle, persistence, and /goal parsing out of AgentSession into a dedicated goals/ feature folder, as the first step in modularizing session execution code.

GoalController now owns transitions (start/clear/pause/resume/complete/fail), token and wall-clock accounting, continuation increments/rollbacks, assistant usage deduplication, and checkpoint/restore for admission races. createGoalPersistence handles branch load/save, immediate flush, and CLI --goal seed eligibility. parseGoalSlashCommand holds slash parsing and budget validation. AgentSession keeps cross-cutting work—queueing goal context messages, continuations after RLM quiescence, host APIs—and delegates mutations through the controller; shared types stay in core/goals.ts.

Adds src/README.md documenting ownership boundaries and ordering invariants (usage before tools, completion clears stale budget context, continuation rollback restores clock). New test/goals/controller.test.ts and harness updates in goal-continuation-quiescence.test.ts exercise the extracted API.

^{Reviewed by Cursor Bugbot for commit 7de5766. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Modularize /goal logic into GoalController and goals/commands.ts

• Extracts goal state ownership, persistence, accounting, and lifecycle transitions from AgentSession into goals/controller.ts and goals/persistence.ts.
• Moves slash-command parsing and objective validation to goals/commands.ts.
• Updates AgentSession to delegate goal operations to GoalController instead of using local goal fields.
• Updates goal-continuation-quiescence.test.ts to use the new controller, and adds controller.test.ts for deterministic lifecycle and accounting tests.
• Risk: AgentSession.goalState now returns GoalController state instead of locally computed wall-clock state; branch reloads now reload the controller from persistence.

^{Macroscope summarized 7de5766.}